Update SetArray to keep old arrays for CEED_COPY_VALUES #1730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremylt
commented
Jan 16, 2025
Comment on lines
-56
to
-59
| if (!*(void **)target_array_owned) CeedCallCuda(ceed, cudaMalloc(target_array_owned, size_unit * num_values)); | ||
| if (source_array) CeedCallCuda(ceed, cudaMemcpy(*(void **)target_array_owned, source_array, size_unit * num_values, cudaMemcpyDeviceToDevice)); | ||
| *(void **)target_array_borrowed = NULL; | ||
| *(void **)target_array = *(void **)target_array_owned; |
There was a problem hiding this comment.
here is where we were always dumping the old borrowed array
jeremylt
force-pushed
the
jeremy/fix-vec-copy
branch
from
13582e7 to
f0c2a8a
Compare
jeremylt
force-pushed
the
jeremy/fix-vec-copy
branch
from
f0c2a8a to
cc3bdf8
Compare
jeremylt
force-pushed
the
jeremy/fix-vec-copy
branch
from
daa84e4 to
99837b8
Compare
jeremylt
commented
Jan 16, 2025
| @@ -359,7 +359,7 @@ def test_126(ceed_resource, capsys): | |||
| a = np.arange(10, 10 + n, dtype=ceed.scalar_type()) | |||
| x.set_array(a, cmode=libceed.USE_POINTER) | |||
|
|
|||
| a2 = np.arange(10, n, dtype=ceed.scalar_type()) | |||
| a2 = np.arange(0, n, dtype=ceed.scalar_type()) | |||
There was a problem hiding this comment.
That's an embarrassing oops on my part from years ago
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1728
Digging in, I think this is the best fix